Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withString #436

Merged
merged 3 commits into from Aug 8, 2022
Merged

Add withString #436

merged 3 commits into from Aug 8, 2022

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Aug 7, 2022

close #434

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2022

Codecov Report

Merging #436 (2fd6eb2) into main (d2980d3) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   95.14%   95.07%   -0.07%     
==========================================
  Files           9        9              
  Lines        1338     1361      +23     
  Branches      124      130       +6     
==========================================
+ Hits         1273     1294      +21     
- Misses         65       67       +2     
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 94.56% <100.00%> (+0.02%) ⬆️
...shared/src/main/scala/cats/parse/Accumulator.scala 97.56% <0.00%> (-2.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@johnynek johnynek merged commit 4f61b18 into main Aug 8, 2022
@johnynek johnynek deleted the oscar/20220807_add_withstring branch August 8, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a withString combinator
3 participants