Add a few new laws and optimizations #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 96.10% 96.88% +0.77%
==========================================
Files 3 3
Lines 565 578 +13
Branches 54 57 +3
==========================================
+ Hits 543 560 +17
+ Misses 22 18 -4
Continue to review full report at Codecov.
|
rossabaker
reviewed
Nov 11, 2020
Comment on lines
840
to
841
| case Impl.Fail() => Impl.Fail() | ||
| case Impl.FailWith(str) => Impl.FailWith(str) |
There was a problem hiding this comment.
Can you reuse the same instances with a cast here?
There was a problem hiding this comment.
I could, but my heuristic is that paser build time is cheap (done once), but parser run time is where we want to optimize, so I didn't bother... but why not...
There was a problem hiding this comment.
😆, I guess we each persuaded the other. I'm happy either way.
|
took your suggestion @rossabaker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more laws occurred to me so I added them.
At the same time, I realized we could leverage some of those properties when statically building up the parsers to make them a bit simpler.