Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize string, void and char cases a bit #67

Merged
merged 2 commits into from Nov 15, 2020

Conversation

johnynek
Copy link
Collaborator

related to #64 here are some special cases to make sure we don't harm efficiency when converting between original, string, and void return types.

cc @rossabaker

@codecov-io
Copy link

Codecov Report

Merging #67 (72acc37) into main (5000dbe) will decrease coverage by 0.27%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   97.11%   96.83%   -0.28%     
==========================================
  Files           3        3              
  Lines         589      601      +12     
  Branches       52       55       +3     
==========================================
+ Hits          572      582      +10     
- Misses         17       19       +2     
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 97.65% <96.29%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5000dbe...72acc37. Read the comment docs.

@johnynek johnynek merged commit 994e954 into main Nov 15, 2020
@johnynek johnynek deleted the oscar/optimize_string_void_cases_20201114 branch November 15, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants