Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type on repAs1 #99

Merged
merged 2 commits into from
Dec 6, 2020
Merged

Fix return type on repAs1 #99

merged 2 commits into from
Dec 6, 2020

Conversation

johnynek
Copy link
Collaborator

This was an oversight: the repAs1 extension method hid that it returns a Parser1

The work around is to directly call the repAs1 method on the Parser companion which does return the correct type.

Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 indeed this makes sense! but now we have MiMa complaining. Is it worth going to 0.2.0?

@johnynek
Copy link
Collaborator Author

@mpilquist since mima stuff seems to be pretty automatic, how is this kind of PR generally merged in such cases? Do we add the exclusions, then publish 0.2, then remove the exclusions?

@rossabaker
Copy link
Member

If you bump the baseVersion to 0.2, I don't think it will check against 0.1 anymore.

@johnynek
Copy link
Collaborator Author

johnynek commented Dec 6, 2020

actually, all the classes in Parser are sealed or final, so I think exclusions would be fine, but 0.1.0 is a low version anyway, so why not go to 0.2.0 when we publish next (I think after adding #101 ).

@codecov-io
Copy link

Codecov Report

Merging #99 (41610ff) into main (3637d52) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files           5        5           
  Lines         676      676           
  Branches       57       57           
=======================================
  Hits          652      652           
  Misses         24       24           
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 97.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923a513...41610ff. Read the comment docs.

@johnynek johnynek merged commit 848b05d into main Dec 6, 2020
@johnynek johnynek deleted the oscar/fix_repas1_return branch December 6, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants