Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add laws for Aspect and Instrument #156

Merged
merged 1 commit into from Aug 7, 2020

Conversation

joroKr21
Copy link
Member

@joroKr21 joroKr21 commented Aug 6, 2020

Also add implicit summoners for Aspect.

Also add implicit summoners for `Aspect`.
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #156 into master will increase coverage by 0.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   90.62%   91.35%   +0.72%     
==========================================
  Files          41       45       +4     
  Lines         512      532      +20     
  Branches        2        2              
==========================================
+ Hits          464      486      +22     
+ Misses         48       46       -2     
Impacted Files Coverage Δ
core/src/main/scala/cats/tagless/aop/Aspect.scala 85.71% <100.00%> (+35.71%) ⬆️
.../src/main/scala/cats/tagless/laws/AspectLaws.scala 100.00% <100.00%> (ø)
.../main/scala/cats/tagless/laws/InstrumentLaws.scala 100.00% <100.00%> (ø)
...ala/cats/tagless/laws/discipline/AspectTests.scala 100.00% <100.00%> (ø)
...cats/tagless/laws/discipline/InstrumentTests.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08acd2f...f6b85a4. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@joroKr21 joroKr21 merged commit 4c1adc9 into typelevel:master Aug 7, 2020
@joroKr21 joroKr21 deleted the aspect-laws branch August 7, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants