Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cats.data.Prod instances #1375

Closed
adelbertc opened this issue Sep 15, 2016 · 7 comments · Fixed by #1402
Closed

More cats.data.Prod instances #1375

adelbertc opened this issue Sep 15, 2016 · 7 comments · Fixed by #1402

Comments

@adelbertc
Copy link
Contributor

https://hackage.haskell.org/package/transformers-0.5.1.0/docs/Data-Functor-Product.html

@pepegar
Copy link
Contributor

pepegar commented Oct 4, 2016

Working on it!

Would it be better to have just all the instances in the same pull request, or is it better to have one pull request for each one?

@adelbertc
Copy link
Contributor Author

@pepegar Awesome, thanks!

I would be fine to just have them all in one PR. Would probably be very annoying for you to have to have N branches for each of the N instances. I'm also guessing you might have to group some of them up if only so you can do things like split out type class implementations into traits so you can re-use them.

@pepegar
Copy link
Contributor

pepegar commented Oct 5, 2016

Instances I've found I think I'll be able to implement are:

  • Monad
  • Foldable
  • Traverse
  • Show

More ideas?

@pepegar
Copy link
Contributor

pepegar commented Oct 5, 2016

Work is being done here

@adelbertc
Copy link
Contributor Author

Looks like you could also do MonadPlus and Ord I think.

@pepegar
Copy link
Contributor

pepegar commented Oct 7, 2016

Maybe I am doing it wrong, but cannot find where MonadPlus is implemented in Cats... Any hint?

@adelbertc
Copy link
Contributor Author

@pepegar pepegar mentioned this issue Oct 7, 2016
6 tasks
@non non closed this as completed in #1402 Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants