Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toValidatedNec to Validated #2487

Merged
merged 2 commits into from Sep 24, 2018
Merged

Add toValidatedNec to Validated #2487

merged 2 commits into from Sep 24, 2018

Conversation

kun-song
Copy link
Contributor

fix the problems in #2472

@kailuowang
Copy link
Contributor

shall we add some tests?

@kun-song
Copy link
Contributor Author

@kailuowang I'll add tests tonight :)

kailuowang
kailuowang approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang requested review from mpilquist and rossabaker and removed request for mpilquist September 17, 2018 21:26
@kailuowang kailuowang added this to the 1.5 milestone Sep 18, 2018
@LukaJCB LukaJCB merged commit e5a6c91 into typelevel:master Sep 24, 2018
@kun-song kun-song deleted the add-toValidatedNec branch September 24, 2018 10:55
@LukaJCB LukaJCB mentioned this pull request Sep 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

@rossabaker rossabaker Awaiting requested review from rossabaker

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.5-RC0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kun-song @kailuowang @LukaJCB