Update sbt-pgp to 1.1.2 #2495
Merged
Update sbt-pgp to 1.1.2 #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scala-steward
force-pushed
the
update/sbt-pgp-1.1.2
branch
from
e4fec0d
to
4ec9c0a
Compare
|
Perhaps not the right place for the discussion, but I would strongly consider using sbt-gpg instead of sbt-pgp. It's considerably simpler and more stable, offering much better compatibility with modern versions of GPG. Since we aren't publishing releases on CI, nothing should need to actually change in the build infrastructure, just swapping out the plugin and removing some of the old settings that were required to make sbt-pgp work. |
scala-steward
force-pushed
the
update/sbt-pgp-1.1.2
branch
from
4ec9c0a
to
38cc1e9
Compare
fthomas
previously approved these changes
Sep 18, 2018
scala-steward
force-pushed
the
update/sbt-pgp-1.1.2
branch
from
38cc1e9
to
fc67aa3
Compare
Codecov Report
@@ Coverage Diff @@
## master #2495 +/- ##
==========================================
+ Coverage 95.35% 95.38% +0.02%
==========================================
Files 358 358
Lines 6530 6605 +75
Branches 282 285 +3
==========================================
+ Hits 6227 6300 +73
- Misses 303 305 +2
Continue to review full report at Codecov.
|
scala-steward
force-pushed
the
update/sbt-pgp-1.1.2
branch
from
fc67aa3
to
b128803
Compare
easel
approved these changes
Sep 25, 2018
larsrh
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update com.jsuereth:sbt-pgp from 1.1.0 to 1.1.2.