Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FullOptStage #3435

Merged
merged 1 commit into from May 28, 2020
Merged

Use FullOptStage #3435

merged 1 commit into from May 28, 2020

Conversation

travisbrown
Copy link
Contributor

This is a follow-up to #3357, where updating the default Scala.js version from 0.6 to 1.1 significantly increased test times. In a couple of quick experiments this change brings them back down part of the way.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #3435 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3435   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         381      381           
  Lines        8268     8268           
  Branches      225      225           
=======================================
  Hits         7577     7577           
  Misses        691      691           
Flag Coverage Δ
#scala_version_212 91.63% <ø> (ø)
#scala_version_213 91.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be11eec...9ef3e71. Read the comment docs.

@mpilquist mpilquist merged commit 9c20c7b into master May 28, 2020
@larsrh larsrh deleted the topic/full-opt-js branch May 28, 2020 18:45
@travisbrown travisbrown added this to the 2.2.0-M3 milestone May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants