Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial semigroup instances #3724

Merged
merged 3 commits into from
Dec 26, 2020

Conversation

RaasAhsan
Copy link

No description provided.

LukaJCB
LukaJCB previously approved these changes Dec 25, 2020
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haskell calls the newtypes First and Last, names I particularly like if we think about combineAll.

Sorry to bikeshed, and 👍 to the spirit of it.

@codecov-io
Copy link

codecov-io commented Dec 25, 2020

Codecov Report

Merging #3724 (78264da) into master (776df87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3724   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         390      390           
  Lines        8863     8865    +2     
  Branches      256      255    -1     
=======================================
+ Hits         7998     8000    +2     
  Misses        865      865           

@RaasAhsan
Copy link
Author

No sweat, I wasn't in love with the names either

@rossabaker rossabaker merged commit 0defa76 into typelevel:master Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants