Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parReduceMapA #4029

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Add parReduceMapA #4029

merged 1 commit into from
Oct 29, 2021

Conversation

isomarcte
Copy link
Member

As parFoldMapA, but for NonEmptyParallel, Reducible, and Semigroup.

Add parReduceMapA
2dd6e2c 
As `parFoldMapA`, but for `NonEmptyParallel`, `Reducible`, and `Semigroup`.
@isomarcte
Copy link
Member Author

isomarcte commented Oct 26, 2021 •
edited

A couple notes here.

  • I placed parReduceMapA in the companion object for Parallel because that is what the idiom seemed to be, though I'm uncertain why it wouldn't be in the companion object for NonEmptyParallel.
  • I named the syntax and ops classes ParallelReduceMapA{Ops,Syntax}, but it seems like NonEmptyParallelReduceMapA{Ops,Syntax} would make more sense. However I didn't see any other classes following that pattern, so again I attempted to follow the current idioms.

If either of these assumptions were wrong, I'm certainly happy to make any changes requested.

@johnynek johnynek merged commit 8787d59 into typelevel:main Oct 29, 2021
@isomarcte isomarcte deleted the parReduceMapA branch October 29, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnynek johnynek johnynek approved these changes

@LukaJCB LukaJCB LukaJCB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isomarcte @johnynek @LukaJCB