Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect deprecated messages #4044

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Incorrect deprecated messages #4044

merged 1 commit into from
Nov 18, 2021

Conversation

jmgimeno
Copy link
Contributor

The deprecated messages were referring to incorrect methods.

Thank you for contributing to Cats!

This is a kind reminder to run sbt +prePR and commit the changed files, if any, before submitting.

The deprecated messages were referring to incorrect methods.
Copy link
Member

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Anybody know why the deprecation version is 3.0.0?

@djspiewak djspiewak merged commit 26cdba3 into typelevel:main Nov 18, 2021
@djspiewak
Copy link
Member

Anybody know why the deprecation version is 3.0.0?

I'm guessing that's because someone thought the listed version should be the removal version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants