more doctests to Reducible #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Mar 16, 2022
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
|
checked it locally after commit (unlucky) and it failed with: Unused import cats.syntax.all._ |
|
@armanbilge is it ok if I 'fix' other tests in this file? or it should be done with another pull request? |
|
Sure, that would be great, thank you very much! |
|
@armanbilge if you could please rerun CI in freetime : ) |
|
Woops, sorry about that! Feel free to ping me if that happens again. |
rossabaker
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added few doctests to reducible,
its my first pr, im open to comments and suggestions