Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stack-safety test for ContT#map #4335

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Add stack-safety test for ContT#map #4335

merged 1 commit into from
Nov 4, 2022

Conversation

eigenvariable
Copy link
Contributor

@eigenvariable eigenvariable commented Nov 3, 2022 •
edited by armanbilge

Issue #2950 has a test that, as of its writing, blows up with a stack safety bug. Sometime in the subsequent 3 years, it must have been fixed. This PR adds the test.

cc @johnynek

Closes #2950.

@armanbilge armanbilge added the behind-the-scenes appreciated, but not user-facing label Nov 3, 2022
@armanbilge armanbilge changed the title test from issue 2950 Add stack-safety test for ContT#map Nov 3, 2022
johnynek
johnynek approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

Always great to have another regression test.

@armanbilge armanbilge merged commit 9c8c5ef into typelevel:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnynek johnynek johnynek approved these changes

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
behind-the-scenes appreciated, but not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContT.map is not stack-safe
3 participants
@eigenvariable @johnynek @armanbilge