Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Applicative#unit in Foldable#traverse_ #4557

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Use Applicative#unit in Foldable#traverse_ #4557

merged 1 commit into from
Feb 3, 2024

Conversation

valencik
Copy link
Member

@valencik valencik commented Feb 3, 2024

Just swaps a G.pure(()) for G.unit to leverage when an instance has an overridden G.unit implementation.

satorg
satorg approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djspiewak djspiewak merged commit f58181d into typelevel:main Feb 3, 2024
16 checks passed
@valencik valencik deleted the dot-units branch February 3, 2024 21:24
@satorg satorg mentioned this pull request Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satorg satorg satorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valencik @satorg @djspiewak