Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken internal link #4622

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Conversation

bwignall
Copy link
Contributor

Current version of the link 404s.

satorg
satorg previously approved these changes Jun 15, 2024
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@satorg
Copy link
Contributor

satorg commented Jun 15, 2024

FutureSuite on JVM is failing again (link)

But despite of that, seems that the site generation step is not happy about this change (link):

[error] laika.api.errors.InvalidDocuments: One or more invalid documents:
[error] /CONTRIBUTING.md
[error] 
[error]   [136]: unresolved internal reference: docs/guidelines.md
[error] 
[error]   [See guidelines](docs/guidelines.md).
[error]   ^
[error] 	at laika.api.errors.InvalidDocuments$.$anonfun$from$7(errors.scala:125)
[error] 	at scala.Option.map(Option.scala:230)
[error] 	at laika.api.errors.InvalidDocuments$.from(errors.scala:125)
[error] 	at laika.api.errors.InvalidDocuments$.$anonfun$from$4(errors.scala:117)
[error] 	at scala.util.Either.fold(Either.scala:191)
[error] 	at laika.api.errors.InvalidDocuments$.from(errors.scala:117)
[error] 	at laika.io.internal.runtime.ParserRuntime$.rewriteTree$1(ParserRuntime.scala:135)
[error] 	at laika.io.internal.runtime.ParserRuntime$.$anonfun$run$35(ParserRuntime.scala:171)
[error] 	at flatMap @ laika.io.internal.runtime.ParserRuntime$.$anonfun$run$34(ParserRuntime.scala:170)
[error] 	at flatMap @ laika.io.internal.runtime.ParserRuntime$.$anonfun$run$33(ParserRuntime.scala:169)
[error] 	at mapN @ laika.helium.internal.builder.HeliumInputBuilder$.build(HeliumInputBuilder.scala:148)
[error] 	at unsafeRunSync @ laika.sbt.Settings$.$anonfun$parserConfig$1(Settings.scala:103)
[error] (docs / laikaSite) laika.api.errors.InvalidDocuments: One or more invalid documents:
[error] /CONTRIBUTING.md
[error] 
[error]   [136]: unresolved internal reference: docs/guidelines.md
[error] 
[error]   [See guidelines](docs/guidelines.md).
[error]   ^

@satorg satorg self-requested a review June 15, 2024 20:09
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel Esik <esik.danny@gmail.com>
@satorg satorg merged commit 84222d5 into typelevel:main Jun 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants