Add Scalastyle #77
Merged
Add Scalastyle #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just kind of went with rules that seemed right for the project. People are free to suggest changes. Currently Scalatest is failing to parse Free.scala which seems like a bug in Scalastyle. The error message is "Free.scala: Expected token RBRACKET but got Token(DOT,.,1985,.)". I believe the following code is tripping it up: ```scala case y: Gosub[S, x.C] => y.a().flatMap(z => y.f(z) flatMap x.f).resume ``` I've got to get to work for now, but I'll follow up on this later.
|
This looks great to me—thanks for putting it together. I don't see a strong need for Scalastyle to run in the test task—we don't want to slow things down until the configuration is settled—but here's a quick example of how you could do it if you wanted to. |
|
This seems good for now. We may want to relax some of these (or add more) as we hit issues, but for now I think it's a good default. 👍 |
|
👍 |
|
Does anyone know what we need to do to make the Travis builds run scalastyle and validate that no errors are detected? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one of the requests made in #50.
I just kind of went with rules that seemed right for the project. People are free to suggest changes.
Currently one has to explicitly run the
scalastyleortest:scalastyletask to check style. Adding linting to the compile task would probably be too slow. We could potentially add it to the test task, but I gave that a quick try and was having some trouble getting it to check the main source in addition to the test source with that approach. Once we have Travis CI integration, we should be able to run the linting without slowing down our compile or test tasks. It might still be worth making one uber sbt task to test and run linting, and I would encourage someone who understands SBT much better than I do to do so! :)