Re-encode Context and events for better compatibility and mockability
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2023
armanbilge
force-pushed
the
topic/tighten-compatibility
branch
from
2126768
to
b6217e2
Compare
armanbilge
changed the title
Context and events for better compatibilityContext and events for better compatibility and mockability
armanbilge
force-pushed
the
topic/tighten-compatibility
branch
from
b6217e2
to
067028f
Compare
|
One thing that's missing from this PR are |
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the pattern of
sealed abstract classes withapplymethods as the public interface andprivate final case classes as the actual implementations.While passing through I did a few other minor tidy-ups.