-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DynamoDBStreamEvent event type #68
Conversation
m: Option[Map[String, AttributeValue]], | ||
n: Option[String], | ||
ns: Option[List[String]], | ||
nul: Option[true], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to drop 2.12 so this should be fine. Literal types yay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh this could be nul: Boolean
, but the decoder will be nastier :(
@kubukoz do you want to update this now that we've dropped 2.12 in main? |
247121c
to
2907801
Compare
That should cut it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the contribution!
No description provided.