Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DynamoDBStreamEvent event type #68

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Dec 9, 2021

No description provided.

m: Option[Map[String, AttributeValue]],
n: Option[String],
ns: Option[List[String]],
nul: Option[true],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to drop 2.12 so this should be fine. Literal types yay!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh this could be nul: Boolean, but the decoder will be nastier :(

@armanbilge
Copy link
Member

@kubukoz do you want to update this now that we've dropped 2.12 in main?

@kubukoz
Copy link
Member Author

kubukoz commented Dec 13, 2021

That should cut it

@kubukoz kubukoz marked this pull request as ready for review December 13, 2021 03:24
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@armanbilge armanbilge merged commit fd76964 into typelevel:main Dec 13, 2021
@kubukoz kubukoz deleted the ddb-stream-event branch December 13, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants