New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten operator for Optional columns. #307
Conversation
imarios
commented
Jun 19, 2018
•
edited
edited
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 52 52
Lines 961 961
Branches 9 9
=======================================
Hits 911 911
Misses 50 50
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really cool! I'm I right saying that this is not in vanilla? A few comments:
-
If not it should probably be better documented, at least with an example.
-
The name make it sound more general that what it is.
.flatten
should be.flatMap(identity)
.
@OlivierBlanvillain Yea, I think in Vanilla you can use Do you have any alternative naming suggestions? |
I seen, then maybe
? |
@OlivierBlanvillain I think |
LGTM! Could you maybe add a minimal example to the scaladoc of For discoverability, what do you think about adding a "new APIs" and "missing APIs" sections to the readme? This way someone familiar with Spark could pickup frameless in no time by looking at this diff. |
@OlivierBlanvillain done! If there are no more suggestions, let me squash and merge. |
LGTM! |