Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CI release #551

Merged
merged 7 commits into from
Aug 26, 2021
Merged

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Aug 25, 2021

This PR closes #550 and closes #445

I'll probably add the release drafter as a part of this PR as well and we need a fancy snapshots icon into the README 🚀

cc @rossabaker @imarios could you set secrets necessary for the release?

PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
PGP_SECRET: ${{ secrets.PGP_SECRET }}
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #551 (3277646) into master (0893463) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          61       61           
  Lines        1051     1051           
  Branches        5        5           
=======================================
  Hits         1012     1012           
  Misses         39       39           
Flag Coverage Δ
2.12.14 96.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0893463...3277646. Read the comment docs.

.gitignore Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@pomadchin pomadchin changed the title [WIP] Add the CI release Add the CI release Aug 25, 2021
@pomadchin
Copy link
Member Author

pomadchin commented Aug 25, 2021

@cchantep release drafter will collect for us the release draft (thx to @sideeffffect for pointing me to that a month ago). (an example of such a draft can be found here https://github.com/sbt/sbt-jni/releases/tag/v1.5.0).

hm it also fails, so probably it can't work until everything lives in the master branch 🤦

Will merge this PR once we have secrets set!

java-version: ${{ matrix.java }}

- name: Cache sbt
uses: actions/cache@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@pomadchin pomadchin Aug 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sideeffffect this file is generated via https://github.com/djspiewak/sbt-github-actions which is used by this project; I just added an extra code here to adjust generator.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see

@rossabaker
Copy link
Member

I usually mess up the first time, but I tried to add the keys. @imarios, feel free to replace with yours if you'd prefer, since you're more involved in this project than me.

@pomadchin
Copy link
Member Author

@rossabaker 🚀 let's try them with snapshots than! merging.

@pomadchin pomadchin merged commit dd7fe91 into typelevel:master Aug 26, 2021
@pomadchin pomadchin deleted the feature/ci-release branch August 26, 2021 18:07
@cchantep
Copy link
Collaborator

Seems ok :

curl -X GET -D -  https://oss.sonatype.org/content/repositories/snapshots/org/typelevel/frameless-core_2.12/0.11.0-SNAPSHOT/frameless-core_2.12-0.11.0-SNAPSHOT.pom
HTTP/2 200 
date: Thu, 26 Aug 2021 18:38:54 GMT
content-type: application/xml
content-length: 3510
server: Nexus/2.14.20-02
x-frame-options: SAMEORIGIN
x-content-type-options: nosniff
accept-ranges: bytes
etag: "{SHA1{e6b7c09ef641b63a701c1a6f467d7a8f6d16767e}}"
last-modified: Thu, 26 Aug 2021 18:37:10 GMT

@rossabaker
Copy link
Member

I don't remember offhand whether that plugin publishes signed snapshots. It might still fail when you tag a release. If it does, and it's still using my credentials, give me another poke.

@pomadchin
Copy link
Member Author

@rossabaker I believe you're right and it skips the sign step for snapshots. Thanks!

@cchantep cchantep mentioned this pull request Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI releases Release automation
4 participants