-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the CI release #551
Add the CI release #551
Conversation
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 61 61
Lines 1051 1051
Branches 5 5
=======================================
Hits 1012 1012
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
519622f
to
64df23c
Compare
5c1269d
to
80cc8e0
Compare
fde4e67
to
f0b89d8
Compare
@cchantep release drafter will collect for us the release draft (thx to @sideeffffect for pointing me to that a month ago). (an example of such a draft can be found here https://github.com/sbt/sbt-jni/releases/tag/v1.5.0). hm it also fails, so probably it can't work until everything lives in the master branch 🤦 Will merge this PR once we have secrets set! |
java-version: ${{ matrix.java }} | ||
|
||
- name: Cache sbt | ||
uses: actions/cache@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just https://github.com/coursier/cache-action/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sideeffffect this file is generated via https://github.com/djspiewak/sbt-github-actions which is used by this project; I just added an extra code here to adjust generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see
I usually mess up the first time, but I tried to add the keys. @imarios, feel free to replace with yours if you'd prefer, since you're more involved in this project than me. |
@rossabaker 🚀 let's try them with snapshots than! merging. |
Seems ok :
|
I don't remember offhand whether that plugin publishes signed snapshots. It might still fail when you tag a release. If it does, and it's still using my credentials, give me another poke. |
@rossabaker I believe you're right and it skips the sign step for snapshots. Thanks! |
This PR closes #550 and closes #445
I'll probably add the release drafter as a part of this PR as well and we need a fancy snapshots icon into the README 🚀
cc @rossabaker @imarios could you set secrets necessary for the release?