Map encoder with Value class #567
Conversation
cchantep
force-pushed
the
feature/map-valueclass-typedencoder
branch
from
f370ae2
to
d947a30
Compare
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 96.35% 95.54% -0.81%
==========================================
Files 63 63
Lines 1071 1101 +30
Branches 9 8 -1
==========================================
+ Hits 1032 1052 +20
- Misses 39 49 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cchantep
force-pushed
the
feature/map-valueclass-typedencoder
branch
from
d947a30
to
fe18ef2
Compare
cchantep
changed the title
|
|
||
| /** | ||
| * @tparam F the value class | ||
| * @tparam G the single field of the value class | ||
| * @tparam H the single field of the value class (with guarantee it's not a `Unit` value) | ||
| * @tparam V the inner value type | ||
| */ | ||
| implicit def valueClass[F : IsValueClass, G <: ::[_, HNil], H <: ::[_, HNil], V] | ||
| implicit def valueClass[F : IsValueClass, G <: ::[_, HNil], H <: ::[_ <: FieldType[_ <: Symbol, _], HNil], K <: Symbol, V, KS <: ::[_ <: Symbol, HNil]] |
There was a problem hiding this comment.
Also capture keys evidence so it can be used to wrap/unwrap in the map/array/collection encoder of Value class
There was a problem hiding this comment.
@cchantep thanks for clarifying it.
|
|
||
| implicit val javaBigDecimalEncoder: TypedEncoder[java.math.BigDecimal] = new TypedEncoder[java.math.BigDecimal] { | ||
| def nullable: Boolean = false | ||
| override def toString: String = "bigDecimalEncoder" |
There was a problem hiding this comment.
Useful when debuging
| @@ -210,29 +226,39 @@ object TypedEncoder { | |||
| ) | |||
| } | |||
|
|
|||
| implicit def arrayEncoder[T: ClassTag](implicit encodeT: TypedEncoder[T]): TypedEncoder[Array[T]] = | |||
| implicit def arrayEncoder[T: ClassTag]( | |||
There was a problem hiding this comment.
Refactor to support array of Value class with the typeclass RecordFieldEncoder (rather than the lower TypedEncoder one)
| } | ||
|
|
||
| import shapeless.{HList, LabelledGeneric} | ||
| import shapeless.test.illTyped | ||
|
|
||
| import org.scalatest.matchers.should.Matchers | ||
|
|
||
| case class UnitsOnly(a: Unit, b: Unit) |
|
@pomadchin This can be reviewed |
|
@cchantep wow a solid PR; will take some time to look through that in the beginning of the work week. |
|
Is that ok for you @pomadchin ? |
|
|
||
| /** | ||
| * @tparam F the value class | ||
| * @tparam G the single field of the value class | ||
| * @tparam H the single field of the value class (with guarantee it's not a `Unit` value) | ||
| * @tparam V the inner value type | ||
| */ | ||
| implicit def valueClass[F : IsValueClass, G <: ::[_, HNil], H <: ::[_, HNil], V] | ||
| implicit def valueClass[F : IsValueClass, G <: ::[_, HNil], H <: ::[_ <: FieldType[_ <: Symbol, _], HNil], K <: Symbol, V, KS <: ::[_ <: Symbol, HNil]] |
There was a problem hiding this comment.
@cchantep thanks for clarifying it.
| @@ -54,15 +55,16 @@ object TypedEncoder { | |||
| Invoke(path, "toString", jvmRepr) | |||
| } | |||
|
|
|||
| implicit val booleanEncoder: TypedEncoder[Boolean] = new TypedEncoder[Boolean] { | |||
There was a problem hiding this comment.
I'm a bit confused by the formatting that happened here, makes it harder to read the diff
| i3: Keys.Aux[H, KS], | ||
| i4: Values.Aux[H, VS], |
There was a problem hiding this comment.
Do we need these constrains here?
i3: Keys.Aux[H, KS],
i4: Values.Aux[H, VS]There was a problem hiding this comment.
Required to call RecordFieldEncoder.valueClass (l80)
pomadchin
changed the title
Closes #566