Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a possible explodeMap column names collision #582

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

pomadchin
Copy link
Member

This PR complements #488 and makes sure that no naming collision happens when performing the explodeMap.

@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #582 (2d43512) into master (20bb12a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          65       65           
  Lines        1134     1134           
  Branches        6        5    -1     
=======================================
  Hits         1079     1079           
  Misses         55       55           
Flag Coverage Δ
2.12.15 95.14% <ø> (ø)
2.13.7 95.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ataset/src/main/scala/frameless/TypedDataset.scala 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bb12a...2d43512. Read the comment docs.

@pomadchin pomadchin merged commit dd77841 into typelevel:master Nov 27, 2021
@pomadchin pomadchin deleted the feature/explode-map-collision branch November 27, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants