Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional Value class as literal #623

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

cchantep
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #623 (025dd9b) into master (29d8d15) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   95.15%   95.20%   +0.04%     
==========================================
  Files          65       65              
  Lines        1157     1168      +11     
  Branches        8        7       -1     
==========================================
+ Hits         1101     1112      +11     
  Misses         56       56              
Flag Coverage Δ
2.12.15 95.20% <100.00%> (+0.04%) ⬆️
2.13.8 95.73% <90.90%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/src/main/scala/frameless/functions/package.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d8d15...025dd9b. Read the comment docs.

@cchantep cchantep requested a review from pomadchin March 30, 2022 22:08
Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 a bit tricky overload though, nice that it works.

@pomadchin pomadchin merged commit 0d711c6 into typelevel:master Mar 30, 2022
@cchantep cchantep deleted the feature/optionalLitVal branch March 30, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants