Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stream.compile.toMap syntax for compiling to a Map #1509

Merged
merged 2 commits into from Jun 13, 2019
Merged

Added stream.compile.toMap syntax for compiling to a Map #1509

merged 2 commits into from Jun 13, 2019

Conversation

zakolenko
Copy link
Contributor

No description provided.

@mpilquist
Copy link
Member

Thanks! This looks good to me. The 2.13 build failed b/c the toString returns HashMap( as the prefix now instead of Map(:

"[Hash]Map(0 -> 0, 1 -> 1, ..." did not equal "[]Map(0 -> 0, 1 -> 1, ..." (StreamDoctest.scala:1110)

Not sure how best to fix this -- maybe add a .mkString(", ")?

@zakolenko
Copy link
Contributor Author

@mpilquist , thanks! I've added .mkString(", ") in 40b9f91

@mpilquist mpilquist merged commit cb349bb into typelevel:series/1.1 Jun 13, 2019
@mpilquist mpilquist modified the milestones: 1.1.0-M2, 1.1.0 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zakolenko @mpilquist