Add Dotty support for FS2 2.x #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilquist
commented
Jul 29, 2020
| @@ -228,8 +229,8 @@ class CompressionSuite extends Fs2Suite { | |||
| test("deflate and inflate are reusable") { | |||
| val bytesIn: Int = 1024 * 1024 | |||
| val chunkSize = 1024 | |||
| val deflater = deflate[IO](bufferSize = chunkSize) | |||
| val inflater = inflate[IO](bufferSize = chunkSize) | |||
| val deflater = deflate[IO](DeflateParams(bufferSize = chunkSize)) | |||
There was a problem hiding this comment.
The other overload is not callable from Dotty -- appears to be a bug with overloads & default parameters, but I haven't minimized it yet.
|
I'm going to eagerly merge this one but feel free to provide review comments and I'll happily address. |
|
Why did so many case classes lose final? Are all case classes final in dotty? |
|
@johnynek case objects are final in dotty -- compiler complains otherwise. Case classes can still be marked final though: scala> final case object One
1 |final case object One
|^^^^^
|final modifier is redundant for objects |
sbuzzard
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports Dotty support to FS2 2.x. Most of the changes are mechanical based on the develop branch, though a handful needed different workarounds. In particular:
debuganddebugChunkstoInvariantOps, which would be a binary incompatible, we use@uncheckedVarianceparJoinandparJoinUnboundedget theirF2[_] <:< F[_]param changed toF2[Any] <:< F[Any](whereas on develop branch, they get moved toInvariantOps)text.base64object to work around Dotty overloading issues