Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple root queries #13

Closed
milessabin opened this issue Jan 13, 2020 · 1 comment
Closed

Add support for multiple root queries #13

milessabin opened this issue Jan 13, 2020 · 1 comment
Assignees
@milessabin
Labels
conformance query execution
Projects
M1

Comments

@milessabin
Copy link
Member

See discussion here. Depends on #12.

This might also interact with staged query coalescing.
@milessabin milessabin self-assigned this Jan 13, 2020
@milessabin milessabin mentioned this issue Jan 13, 2020
Closed
@milessabin milessabin added this to In progress in M1 Jan 13, 2020
milessabin added a commit that referenced this issue Jan 17, 2020
@milessabin
Add support for field aliases and multiple root fields
8706798 
It is now possible for a query to contain more than root field as
described in the spec discussion linked to in #13. Where the root
queries differ only in their arguments they must be renamed using
field aliases (described in section 2.7 of the spec) to ensure that
their result fields don't conflict.

Adding the support for renaming revealed a bug in the schema/interpreter
composition mechanism which is now fixed.

Adding support for multiple root nodes revealed a bug in the handling of
Unique queries where the expected type is nullable. Prior to this
commit, if there was no unique match the query would fail incorrectly
rather than returning a null value. This is now also fixed.
@milessabin milessabin mentioned this issue Jan 17, 2020
Merged
@milessabin
Copy link
Member Author

Fixed in #39.

M1 automation moved this from In progress to Done Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milessabin milessabin

Labels
conformance query execution
Projects
M1
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@milessabin