Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax for F[Either[A, B]] #243

Merged
merged 7 commits into from
Oct 7, 2021
Merged

Add syntax for F[Either[A, B]] #243

merged 7 commits into from
Oct 7, 2021

Conversation

danicheg
Copy link
Member

@danicheg danicheg commented Oct 4, 2021

This adds syntax for F[Either[A, B]]. As well as for F[Option[A]], sometimes using monad transformers is not applicable (or F[Either[A, B]] just more preferred).

@danicheg
Copy link
Member Author

danicheg commented Oct 6, 2021

@benhutchison I'd be so grateful for a review if you have time for it.

@benhutchison
Copy link
Member

Nice! I like the symmetry between F[Option[A]] and F[Either[L, R]].

IIUC, these operations offer a "lite" way to work with 2-deep stacks without needing monad transformers. I wonder if a dedicated section of the documentation is useful to explain the concept?

The simple list of examples in mouse is pretty minimal. Feels like the sophistication & capability of this design may not be visible to users, and these features may get less use than they deserve..?

@danicheg
Copy link
Member Author

danicheg commented Oct 7, 2021

IIUC, these operations offer a "lite" way to work with 2-deep stacks without needing monad transformers. I wonder if a dedicated section of the documentation is useful to explain the concept?

The simple list of examples in mouse is pretty minimal. Feels like the sophistication & capability of this design may not be visible to users, and these features may get less use than they deserve..?

Yeah, I have the same thoughts on mouse documentation. Perhaps mouse is ready for its site? I planned to open an issue to discuss it after work on the F[Either[L, R]] syntax.

@danicheg danicheg merged commit 2f27823 into main Oct 7, 2021
@danicheg danicheg deleted the feither branch October 7, 2021 10:04
@danicheg danicheg mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants