-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Scala Native #371
Conversation
@armanbilge recently did a lot of work on adding Scala Native support within Typelevel projects. So, If you can have a look at this PR, it'd be great. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for cross-building your popular library for Scala Native!! 🙏
@@ -10,24 +10,25 @@ ThisBuild / crossScalaVersions := Seq(Scala212, Scala3, Scala213) | |||
ThisBuild / tlVersionIntroduced := Map("3" -> "1.0.3") | |||
ThisBuild / tlCiReleaseBranches := Seq("main") | |||
ThisBuild / tlSiteApiUrl := Some(url("https://www.javadoc.io/doc/org.typelevel/mouse_2.13/latest")) | |||
ThisBuild / githubWorkflowOSes := Seq("ubuntu-22.04") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you can continue to use the default here.
http4s and FS2 needed ubuntu-22.04
because they have additional requirements on a TLS library that I was having trouble using on ubuntu 20.04.
https://github.com/aws/s2n-tls
TLS and cryptography are the only requirement we cannot easily reimplement in pure Scala, that would be a bad idea 😅 so they are a little more hassle unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's good to know. Thanks!
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
*/ | ||
|
||
package object mouse extends MouseFunctions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this identical with jvm and/or js? You can put it in a js-native
or jvm-native
folder so you do not need to copy the sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it slightly differs from JS/JVM already. So I split it into different sources straightaway.
assertEquals("blah".parseInt.leftMap(_.getMessage.replace("string ", "string: ")), | ||
"For input string: \"blah\"".asLeft | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, is this a bug where behavior doesn't match? Can you make an issue so we fix this in Scala Native core 🙏 thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only difference is in the lack of colon. That's so minor thing, but if you say so, let's try to fix it :)
No description provided.