Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scalafix migration rules #426

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Jan 11, 2024

Closes #413.

The changes:

- import org.typelevel.otel4s.java._
+ import org.typelevel.otel4s.oteljava._ 

- meter.counter("counter").create
+ meter.counter[Long]("counter").create

- meter.histogram("histogram").withUnit("unit").create
+ meter.histogram[Double]("histogram").withUnit("unit").create

- meter.upDownCounter("upDownCounter").create
+ meter.upDownCounter[Long]("upDownCounter").create

- meter.observableGauge("observableGauge").create(Async[F].pure(Nil))
+ meter.observableGauge[Double]("observableGauge").create(Async[F].pure(Nil))

- meter.observableCounter("observableCounter").create(Async[F].pure(Nil))
+ meter.observableCounter[Long]("observableCounter").create(Async[F].pure(Nil))

- meter.observableUpDownCounter("observableUpDownCounter").create(Async[F].pure(Nil))    
+ meter.observableUpDownCounter[Long]("observableUpDownCounter").create(Async[F].pure(Nil))

@iRevive iRevive merged commit 47b737d into typelevel:main Jan 30, 2024
10 checks passed
@iRevive iRevive deleted the scalafix branch January 30, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare scalafix rules to ease the migration
1 participant