Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala 3 + Native #504

Merged
merged 10 commits into from
Oct 31, 2022
Merged

Conversation

armanbilge
Copy link
Member

No description provided.

… and 'upstream/update/scala3-library-3.2.0' into feature/native-3
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Merging #504 (a7e820b) into master (1da9c6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files           7        7           
  Lines         425      425           
  Branches       79       79           
=======================================
  Hits          421      421           
  Misses          4        4           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment on lines +50 to +57
mimaBinaryIssueFilters ++= {
if (tlIsScala3.value) {
import com.typesafe.tools.mima.core._
Seq(
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.typelevel.paiges.Chunk*")
)
} else Nil
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala 3.1.1+ broke bincompat for some private constructors.

Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants