Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Scalafix migration for v0.5.0 #88

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Conversation

DavidGregory084
Copy link
Member

@DavidGregory084 DavidGregory084 commented Jul 21, 2022

This uses the ScalafixProjectPlugin that @armanbilge extracted in typelevel-scalafix. Unfortunately we can't use all of the conveniences of sbt-typelevel here yet. 馃槢

Fixes #86.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit confused at first why the build changed so much :)

build.sbt Outdated Show resolved Hide resolved
@armanbilge
Copy link
Member

Btw I haven't forgotten your question from the other PR about considering whether we should fold sbt-tpolecat under sbt-typelevel. There's pros/cons both ways, it won't be an easy one :)

@DavidGregory084
Copy link
Member Author

I was a bit confused at first why the build changed so much :)

I should have converted this to a multi module build a long time ago, but I actually quite like the top-level settings style 馃槩

@DavidGregory084
Copy link
Member Author

DavidGregory084 commented Jul 21, 2022

Btw I haven't forgotten your question from the other PR about considering whether we should fold sbt-tpolecat under sbt-typelevel. There's pros/cons both ways, it won't be an easy one :)

Yeah, and I guess it's not a super urgent question - but we may only get this opportunity once as the planets aligned and both projects are working on 0.5.x at the same time 馃榿

@DavidGregory084 DavidGregory084 merged commit 472aa88 into main Jul 21, 2022
@DavidGregory084 DavidGregory084 deleted the v0_5-migration-rule branch July 21, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a Scalafix migration to migrate usages of the old package name
2 participants