Verify only props matching the given TestSelectors #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duhemm
force-pushed
the
test-selector
branch
2 times, most recently
from
46dbc34
to
7d9e2a9
Compare
Previously, ScalaCheck ignored the selectors that it receives as input in the "root task". This prevented users from running only a subset of properties in a specification by passing their `TestSelector` to ScalaCheck in a `TaskDef`. This patch fixes this by having the root task program the execution of only the requested properties if the `TaskDef` contains only `TestSelector`s. ScalaCheck's behavior remains unchanged if the `TaskDef` contains any other kind of `Selector`.
|
Hi @satorg! Would you mind taking a look at this PR, please? |
|
@satorg Hi! Any concerns with this PR? |
|
Hi @Duhemm ! Thank you for the ping. I'm really sorry that it takes so much time to review your PR. Honestly, I made a couple of attempts to look into it, but every time was realizing that I'm not really sure what the problem the PR is aimed to solve. It does not mean that there's anything wrong with your PR, but rather it seems that I've never encountered that kind of issue in my personal experience. So I would really appreciate if you could elaborate a bit more on the issue the PR is addressing, maybe with some really small examples. I believe it could help to move it forward. Anyway, thank you for contributing to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ScalaCheck ignored the selectors that it receives as input in the "root task". This prevented users from running only a subset of properties in a specification by passing their
TestSelectorto ScalaCheck in aTaskDef.This patch fixes this by having the root task program the execution of only the requested properties if the
TaskDefcontains onlyTestSelectors. ScalaCheck's behavior remains unchanged if theTaskDefcontains any other kind ofSelector.