Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add open to Properties to prevent Scala 3 compile errors #991

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Add open to Properties to prevent Scala 3 compile errors #991

merged 1 commit into from
Sep 12, 2023

Conversation

froth
Copy link
Contributor

@froth froth commented Jul 27, 2023

When extending Properties in a Scala 3 code base one currently has to use scala.language.adhocExtensions.
According to the documentation Properties is clearly intended for extension.

satorg
satorg approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you!

@satorg satorg merged commit 8c665dc into typelevel:main Sep 12, 2023
18 checks passed
@froth froth deleted the openProperties branch September 13, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satorg satorg satorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@froth @satorg