Fix #1042 - deadlock in session pool #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
+ Coverage 83.91% 83.94% +0.02%
==========================================
Files 138 138
Lines 2133 2136 +3
Branches 243 243
==========================================
+ Hits 1790 1793 +3
Misses 343 343 ☔ View full report in Codecov by Sentry. |
mpilquist
commented
Mar 30, 2024
| @@ -152,7 +152,7 @@ object Pool { | |||
| ref.modify { | |||
| case (os, Nil) => ((os :+ None, Nil), ().pure[F]) // new empty slot | |||
| case (os, d :: ds) => ((os, ds), Concurrent[F].attempt(rsrc(Tracer[F]).allocated).flatMap(d.complete).void) // alloc now! | |||
| } .guarantee(a._2).flatten | |||
| }.flatten.guarantee(a._2) | |||
There was a problem hiding this comment.
Upon losing connection to the server, this dispose is called. The deferred removed here (d) should be completed but it's not b/c the finalizer of A completes with the connection error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1042. Issue occurred when (a) allocated resource failed to be returned to the pool and (b) resource finalizer also failed with an error.