docs: add required import for Scala 2 #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilquist
reviewed
Jun 30, 2023
| @@ -3,6 +3,8 @@ | |||
| Twiddle lists are tuples that are built incrementally, element by element, via the `*:` operation. Skunk uses the [Typelevel Twiddles](https://github.com/typelevel/twiddles) library for parameter encoders and row decoders, and via this mechanism twiddle list types appear as type arguments for `Query` and `Command`. | |||
|
|
|||
| ```scala | |||
| import org.typelevel.twiddles._ // required for Scala 2 | |||
There was a problem hiding this comment.
Can we move this import down to the example that defines t1, t2, etc?
Codecov Report
@@ Coverage Diff @@
## main #910 +/- ##
=======================================
Coverage 83.89% 83.90%
=======================================
Files 125 125
Lines 1757 1758 +1
Branches 211 212 +1
=======================================
+ Hits 1474 1475 +1
Misses 283 283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.