Fix for #990 - nested fragment interpolation #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## series/0.6.x #991 +/- ##
=============================================
Coverage 84.27% 84.27%
=============================================
Files 126 126
Lines 1736 1736
Branches 160 160
=============================================
Hits 1463 1463
Misses 273 273 ☔ View full report in Codecov by Sentry. |
mpilquist
commented
Oct 10, 2023
| else if legacyCommandSyntax then encoders.reduceLeft { | ||
| case ('{$a : Encoder[a]}, '{ $b : Encoder[b] }) => '{$a ~ $b} | ||
| } else encoders.reduceRight { | ||
| case ('{$a : Encoder[a]}, '{ $b : Encoder[bh *: bt] }) => '{$a *: $b} |
There was a problem hiding this comment.
Main issue was here, where the nested encoder would cause this line to be matched instead of the next line, resulting in extending the tuple type of the fragment encoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#990