use special Scala 2.11 sources for 2.12 too #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 48.48% (diff: 100%)@@ master #587 diff @@
==========================================
Files 181 181
Lines 11471 11471
Methods 9808 9808
Messages 0 0
Branches 1619 1619
==========================================
+ Hits 5517 5562 +45
+ Misses 5954 5909 -45
Partials 0 0
|
This was referenced Oct 13, 2016
SethTisue
added a commit
to SethTisue/community-build
that referenced
this pull request
Oct 14, 2016
now that typelevel/spire#587 was merged
|
Here's one way to dedup if anyone is interested: https://github.com/milessabin/shapeless/blob/6cbe70e43e38a9c6f340aa0f2dc2065e6c8685a5/build.sbt#L200-L210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if copying these sources is the ideal way to resolve this
-- y'all can decide for yourselves. but I need some change along these
lines in order to resume tracking Spire's master branch in the Scala
2.12 community build.
note that CrossVersion.partialVersion will do the right thing even
for Scala milestones and RCs, weird dbuild-generated community
build Scala version numbers, etc.