#323 adding hashcode to Money #351
Conversation
| @@ -14,6 +14,7 @@ import scala.util.{Failure, Success, Try} | |||
| import scala.language.implicitConversions | |||
| import scala.math.BigDecimal.RoundingMode | |||
| import scala.math.BigDecimal.RoundingMode.RoundingMode | |||
| import java.util.Objects | |||
There was a problem hiding this comment.
This is import is unused and it is breaking the build
There was a problem hiding this comment.
I removed the java.util package from the hash function.
| @@ -377,6 +384,9 @@ final class Money private (val amount: BigDecimal)(val currency: Currency) | |||
| * @return Money | |||
| */ | |||
| def mapAmount(f: BigDecimal => BigDecimal) = currency(f(amount)) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Could you remove the extra lines?
There was a problem hiding this comment.
I fixed the formatting back to the original(style).
|
@cquiroz can somebody merge looks like I don't have the permission to do that. |
|
@Vrolijkx We've had the policy of having two people approve a PR, however if nobody approves in a few days I'll merge. I was hoping to use your PR to test the automated release but I think I won't be ready by then |
| it should "return consistent hashcode" in { | ||
| val someMoney = USD(2.1) | ||
|
|
||
| someMoney.hashCode() shouldBe someMoney.hashCode() |
There was a problem hiding this comment.
Java requires equal hash codes for equal objects, so I suggest adding a test which also checks against another instance of USD(2.1)
PR to solve bug #323.
This makes it possible to use Money and Price objects correctly in Sets/Maps. Or when these objects are nested in a case class