Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala3-library_3 to 3.4.0 #131

Closed
wants to merge 1 commit into from

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scala-lang:scala3-library_3 from 3.3.3 to 3.4.0

πŸ“œ GitHub Release Notes - Version Diff - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-library_3" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala3-library_3" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:semver-spec, commit-count:1

@rossabaker
Copy link
Member

Do we need to tweak our pins? I'm surprised to see this.

@valencik
Copy link
Member

valencik commented Mar 2, 2024

I don't think we have had the Scala versions pinned before.
But with 3.3 being LTS and 3.4 not, I think it's reasonable to revisit this.

I think the recommended path forward is that libraries continue publishing for 3.3, and 3.4+ would be yet another cross version.
So we don't want to merge this as is. But perhaps we want to add an option to additionally compile against 3.4?

@armanbilge
Copy link
Member

Do we need to tweak our pins? I'm surprised to see this.

@typelevel-steward
Copy link
Contributor Author

Superseded by #135.

@typelevel-steward typelevel-steward bot deleted the update/scala3-library_3-3.4.0 branch March 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants