Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Operadics be in Cartfile.private? #21

Closed
griotspeak opened this issue Jul 18, 2015 · 13 comments
Closed

Should Operadics be in Cartfile.private? #21

griotspeak opened this issue Jul 18, 2015 · 13 comments

Comments

@griotspeak
Copy link

Operadics seems necessary to build Swiftx but is not pulled down by carthage update when I depend on Swiftx from a mac project. If I cd into /Carthage/Checkouts/Swiftx and then run carthage bootstrap, I can then get the mac app to run carthage update successfully but codesign fails.

Failure aside, it looks as though Cartfile.private should be used for dependencies that aren't necessarily useful in release but that doesn't look like a fitting description of Operadics

@CodaFi
Copy link
Member

CodaFi commented Jul 18, 2015

Methinks what happened is I didn't --use-submodules for Operadics the first time around. That should resolve your problem and stuff for anyone else who doesn't want to use Carthage.

@CodaFi
Copy link
Member

CodaFi commented Jul 18, 2015

I've resolved this in #20. Let me know if that fixes anything.

@griotspeak
Copy link
Author

That changed some things. Now I get

A shell task failed with exit code 65:
** BUILD FAILED **
The following build commands failed:
CompileSwift normal x86_64     ~/Development/ChordalText/Carthage/Checkouts/Swiftx/SwiftxTests/SectionSpec.swift
CompileSwift normal x86_64     ~/Development/ChordalText/Carthage/Checkouts/Swiftx/SwiftxTests/EitherSpec.swift
CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(3 failures)`

in the log:
~/Development/ChordalText/Carthage/Checkouts/Swiftx/SwiftxTests/SectionSpec.swift:11:8: error: no such module 'SwiftCheck' import SwiftCheck

@CodaFi
Copy link
Member

CodaFi commented Jul 18, 2015

Well, shit. This is why I need build tools backing my commits 😞. Testing bundle didn't have SwiftCheck copied along with everything else. That part is fixed by #23, or at least --no-skip-current doesn't bork.

@CodaFi
Copy link
Member

CodaFi commented Jul 18, 2015

So this doesn't happen again, can you checkout #23 just to make sure I have everything in place?

@griotspeak
Copy link
Author

I think that you missed adding the SwiftCheck.xcodeproj to Swiftx.xcodeproj

@CodaFi
Copy link
Member

CodaFi commented Jul 19, 2015

It's under Supporting Files.

@CodaFi
Copy link
Member

CodaFi commented Jul 19, 2015

Wipe out your Carthage directory. It won't checkout the submodules otherwise.

@griotspeak
Copy link
Author

My apologies. It checked it out just fine before as well. Xcode simply expects it in the wrong place.
Expected at ~/Development/ChordalText/Carthage/Checkouts/SwiftCheck/SwiftCheck.xcodeproj
when it is actually at ~/Development/ChordalText/Carthage/Checkouts/Swiftx/Carthage/Checkouts/SwiftCheck

screen shot 2015-07-19 at 9 05 46 am

@griotspeak
Copy link
Author

Is this a carthage setup issue or some other thing? Seems like it is set up with a relative path from the top instead of from swiftx.

EDIT: Yes. The path should be based on the PROJECT_DIR, I think.

@CodaFi
Copy link
Member

CodaFi commented Jul 20, 2015

So the lesson here is: never trust Xcode to do the right thing the first time around. I've committed a fix (hopefully) in that branch.

@griotspeak
Copy link
Author

It builds 👍 Thanks for the help!

@CodaFi
Copy link
Member

CodaFi commented Jul 20, 2015

Then it is merged. Fuck all.

@CodaFi CodaFi closed this as completed Jul 20, 2015
DanielAsher pushed a commit to DanielAsher/Swiftx that referenced this issue Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants