Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lenses and indexed state #34

Merged
merged 4 commits into from
Jun 12, 2014
Merged

Lenses and indexed state #34

merged 4 commits into from
Jun 12, 2014

Conversation

pthariensflame
Copy link
Member

Since I just added IxCont, I felt like I should also implement IxState, and in the process I realized that the prior implementation of lenses was kind of ad-hoc, so I replaced it with a more capable implementation based on coalgebroids of the indexed store comonad (not implemented separately for now).

@mxswd
Copy link
Contributor

mxswd commented Jun 12, 2014

@pthariensflame Ok wow, Data.Lens lenses are definitely more useful. My only question is, can Lens now become a struct?

@pthariensflame
Copy link
Member Author

@maxpow4h I don't see why not! I'll make that change.

@pthariensflame
Copy link
Member Author

@maxpow4h Done!

mxswd added a commit that referenced this pull request Jun 12, 2014
@mxswd mxswd merged commit 31503af into typelift:master Jun 12, 2014
@mxswd
Copy link
Contributor

mxswd commented Jun 12, 2014

Thanks a lot! Lenses for all indeed! 😃

@pthariensflame pthariensflame deleted the topic/ixstate branch June 12, 2014 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants