Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-8: Update next-redux-wrapper #85

Merged
merged 5 commits into from
Jun 8, 2020
Merged

Issue-8: Update next-redux-wrapper #85

merged 5 commits into from
Jun 8, 2020

Conversation

mczeplowski
Copy link
Member

@mczeplowski mczeplowski commented Jun 8, 2020 •
edited by typeofweb
Loading

Fixes #8

@typeofweb typeofweb force-pushed the issue-8-migrate-from-getinitialprops branch from 2bf4ba6 to a9cc0a6 Compare June 8, 2020 10:42
typeofweb
typeofweb previously approved these changes Jun 8, 2020
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TypeofWebBot
Copy link
Collaborator

Fails
🚫 Couldn't show Lighthouse results because: Deployment not ready yet!

Bundle size changes

Comparing: e0512fd...e23c474

Summary

  • Size change: ▼ -1.99 kB (-1.19% )
  • Size: 165 kB
Details of page changes
File Size Change Size
static/pages/_app.module.js ▼ -2 kB (-6.71% ) 27.8 kB
/ ▲ +15 B (+2.07% ) 738 B
/questions ▲ +10 B (+1.37% ) 739 B
/questions/p/[id] ▼ -10 B (-0.43% ) 2.33 kB
/404 -- 2.17 kB
/about -- 1.54 kB
/admin -- 2.54 kB
/authors -- 1.06 kB
/login -- 999 B
/questions/[technology] -- 5 kB
/regulations -- 5.1 kB
/selected-questions -- 2.58 kB
/sitemap.xml -- 1.6 kB
shared:chunk/framework -- 40.5 kB
shared:css -- 0 B
shared:js -- 61.5 kB
shared:runtime/main -- 7.24 kB
shared:runtime/webpack -- 1.71 kB

Generated by 🚫 dangerJS against e23c474

@typeofweb typeofweb merged commit 3ab7b4c into typeofweb-org:develop Jun 8, 2020
@typeofweb typeofweb mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typeofweb typeofweb typeofweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update next redux wrapper
3 participants
@mczeplowski @TypeofWebBot @typeofweb