Skip to content

Commit

Permalink
fix: fixes the typescript errors in EntityCreateCommand & SubscriberC…
Browse files Browse the repository at this point in the history
…reateCommand (#6824)

somehow #6807 passed as a PR but failed when merged in - this fixes the issues
that cropped up after it was merged in
  • Loading branch information
imnotjames committed Oct 1, 2020
1 parent d9a76e9 commit 0221a93
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/commands/EntityCreateCommand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class EntityCreateCommand implements yargs.CommandModule {
configName: args.config as any
});
const connectionOptions = await connectionOptionsReader.get(args.connection as any);
directory = connectionOptions.cli ? connectionOptions.cli.entitiesDir : undefined;
directory = connectionOptions.cli ? (connectionOptions.cli.entitiesDir || "") : "";
} catch (err) { }
}

Expand Down
2 changes: 1 addition & 1 deletion src/commands/SubscriberCreateCommand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class SubscriberCreateCommand implements yargs.CommandModule {
configName: args.config as any
});
const connectionOptions = await connectionOptionsReader.get(args.connection as any);
directory = connectionOptions.cli ? connectionOptions.cli.subscribersDir : undefined;
directory = connectionOptions.cli ? (connectionOptions.cli.entitiesDir || "") : "";

This comment has been minimized.

Copy link
@gtpan77

gtpan77 Oct 1, 2020

Contributor

@imnotjames subscribersDir not entitiesDir

This comment has been minimized.

Copy link
@imnotjames

imnotjames Oct 1, 2020

Author Contributor

Oh no! You're very right. Thanks for catching that!

This comment has been minimized.

Copy link
@imnotjames

imnotjames Oct 1, 2020

Author Contributor

😊 Updated.

This comment has been minimized.

Copy link
@gtpan77

gtpan77 Oct 1, 2020

Contributor

It was the least I could do. 👍

} catch (err) { }
}

Expand Down

0 comments on commit 0221a93

Please sign in to comment.