fix: avoid regex lookbehind for compatibility (#7270)

Lookbehind isn't supported in Safari/JavaScriptCore environments. Closes: #7026
typeorm · Jan 18, 2021 · 063d27f · 063d27f
1 parent aea2786
commit 063d27f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/query-builder/QueryBuilder.ts b/src/query-builder/QueryBuilder.ts
@@ -624,12 +624,13 @@ export abstract class QueryBuilder<Entity> {
 
             if (replacementKeys.length) {
                 statement = statement.replace(new RegExp(
-                    `(?<=[ =\(]|^.{0})` +
+                    // Avoid a lookbehind here since it's not well supported
+                    `([ =\(]|^.{0})` +
                     `${escapeRegExp(replaceAliasNamePrefix)}(${replacementKeys.map(escapeRegExp).join("|")})` +
                     `(?=[ =\)\,]|.{0}$)`,
                     "gm"
-                ), (_, p) =>
-                    `${replacementAliasNamePrefix}${this.escape(replacements[p])}`
+                ), (_, pre, p) =>
+                    `${pre}${replacementAliasNamePrefix}${this.escape(replacements[p])}`
                 );
             }
         }