added tests for #813

src/query-builder/SelectQueryBuilder.ts

@@ -1584,6 +1584,8 @@ export class SelectQueryBuilder<Entity> extends QueryBuilder<Entity> {
 
         const selectString = Object.keys(orderBys)
             .map(columnName => {
+                if (columnName.indexOf(".") === -1) return;
+
                 const [aliasName, propertyPath] = columnName.split(".");
                 const alias = this.expressionMap.findAliasByName(aliasName);
                 const column = alias.metadata.findColumnWithPropertyName(propertyPath);
@@ -1593,6 +1595,8 @@ export class SelectQueryBuilder<Entity> extends QueryBuilder<Entity> {
 
         const orderByObject: OrderByCondition = {};
         Object.keys(orderBys).forEach(columnName => {
+            if (columnName.indexOf(".") === -1) return;
+
             const [aliasName, propertyPath] = columnName.split(".");
             const alias = this.expressionMap.findAliasByName(aliasName);
             const column = alias.metadata.findColumnWithPropertyName(propertyPath);

test/github-issues/813/entity/Post.ts

@@ -0,0 +1,14 @@
+import {Entity} from "../../../../src/decorator/entity/Entity";
+import {PrimaryGeneratedColumn} from "../../../../src/decorator/columns/PrimaryGeneratedColumn";
+import {Column} from "../../../../src/decorator/columns/Column";
+
+@Entity()
+export class Post {
+
+    @PrimaryGeneratedColumn()
+    id: number;
+
+    @Column()
+    title: string;
+
+}

test/github-issues/813/issue-813.ts

@@ -0,0 +1,53 @@
+import "reflect-metadata";
+import {closeTestingConnections, createTestingConnections, reloadTestingDatabases} from "../../utils/test-utils";
+import {Connection} from "../../../src/connection/Connection";
+import {Post} from "./entity/Post";
+
+describe("github issues > #813 order by must support functions", () => {
+
+    let connections: Connection[];
+    before(async () => connections = await createTestingConnections({
+        entities: [__dirname + "/entity/*{.js,.ts}"],
+        schemaCreate: true,
+        dropSchema: true,
+    }));
+    beforeEach(() => reloadTestingDatabases(connections));
+    after(() => closeTestingConnections(connections));
+
+    it("should work perfectly", () => Promise.all(connections.map(async connection => {
+
+        const post = new Post();
+        post.title = "About order by";
+        await connection.manager.save(post);
+
+        const posts = await connection.createQueryBuilder(Post, "post")
+            .orderBy("RAND()")
+            .getMany();
+
+        posts.should.be.eql([{
+            id: 1,
+            title: "About order by"
+        }]);
+
+    })));
+
+    it("should work perfectly with pagination as well", () => Promise.all(connections.map(async connection => {
+
+        const post = new Post();
+        post.title = "About order by";
+        await connection.manager.save(post);
+
+        const posts = await connection.createQueryBuilder(Post, "post")
+            .orderBy("RAND()")
+            .skip(0)
+            .take(1)
+            .getMany();
+
+        posts.should.be.eql([{
+            id: 1,
+            title: "About order by"
+        }]);
+
+    })));
+
+});