fix: use last item in value array in the case of duplicate columns (m…

…ssql)

Brings mssql driver in line with other drivers in handling resultsets with duplicate columns

Closes: #7775

src/driver/sqlserver/SqlServerQueryRunner.ts

@@ -269,6 +269,22 @@ export class SqlServerQueryRunner
 
             if (raw?.hasOwnProperty("recordset")) {
                 result.records = raw.recordset
+                // mssql driver will return an array if duplicate columns exist
+                // The following will search for properties that return as an array, and then update the property with the last value
+                if (result.records?.length > 0) {
+                    const propsToTakeForDuplicate = []
+                    for (let prop in result.records[0]) {
+                        if (Array.isArray(result.records[0][prop])) {
+                            propsToTakeForDuplicate.push(prop)
+                        }
+                    }
+                    for (let record of result.records) {
+                        for (let prop of propsToTakeForDuplicate) {
+                            const lastIdx = record[prop].length - 1
+                            record[prop] = record[prop][lastIdx]
+                        }
+                    }
+                }
             }
 
             if (raw?.hasOwnProperty("rowsAffected")) {

test/github-issues/7775/entities/test.ts

@@ -0,0 +1,26 @@
+import {
+    Entity,
+    JoinColumn,
+    ManyToOne,
+    OneToMany,
+    PrimaryGeneratedColumn,
+} from "../../../../src"
+
+@Entity("parent")
+export class Parent {
+    @PrimaryGeneratedColumn()
+    id: number
+
+    @OneToMany((type) => Child, (child) => child.parent)
+    children: Child[]
+}
+
+@Entity("child")
+export class Child {
+    @PrimaryGeneratedColumn()
+    id: number
+
+    @ManyToOne((type) => Parent, (parent) => parent.children)
+    @JoinColumn({ name: "parent_id" })
+    parent: Parent
+}

test/github-issues/7775/issue-7775.ts

@@ -0,0 +1,72 @@
+import { expect } from "chai"
+import "reflect-metadata"
+import { DataSource } from "../../../src"
+import {
+    closeTestingConnections,
+    createTestingConnections,
+    reloadTestingDatabases,
+} from "../../utils/test-utils"
+import { Child, Parent } from "./entities/test"
+
+describe("github issues > #7775 MSSQL: Duplicate columns names return as an array, potentially breaking mapping", () => {
+    let connections: DataSource[]
+    before(async () => {
+        connections = await createTestingConnections({
+            enabledDrivers: ["mssql"],
+            entities: [Parent, Child],
+            dropSchema: true,
+            schemaCreate: true,
+        })
+    })
+    beforeEach(() => reloadTestingDatabases(connections))
+    after(() => closeTestingConnections(connections))
+
+    it("should take the last column as the value, consistent with other drivers", () =>
+        Promise.all(
+            connections.map(async (connection) => {
+                const results = await connection.manager.query(
+                    `SELECT 1 as id, 2 as id UNION SELECT 5, NULL`,
+                )
+                expect(results.length).to.be.eql(2)
+                expect(results[0].id).to.be.eql(2)
+                expect(results[1].id).to.be.eql(null)
+            }),
+        ))
+
+    it("should map the data properly if duplicate columns are present", () =>
+        Promise.all(
+            connections.map(async (connection) => {
+                const parentRepo = await connection.getRepository(Parent)
+                const childRepo = await connection.getRepository(Child)
+
+                const parent = new Parent()
+                parent.id = 1
+
+                await parentRepo.save(parent)
+
+                const child = new Child()
+                child.id = 1
+                child.parent = parent
+
+                await childRepo.save(child)
+
+                const results = await connection
+                    .getRepository(Child)
+                    .createQueryBuilder("child")
+                    .andWhere("parent.id = :p0")
+                    .setParameters({ p0: 1 })
+                    .select(
+                        "child.id, child.parent"
+                            .split(",")
+                            .map((i) => i.trim()),
+                    )
+                    .leftJoinAndSelect("child.parent", "parent", "1 = 1")
+                    .getMany()
+
+                expect(results.length).to.be.eql(1)
+                expect(results[0]).to.be.instanceOf(Child)
+                expect(results[0].parent).to.be.instanceOf(Parent)
+                expect(results[0].parent.id).to.be.eq(1)
+            }),
+        ))
+})