Skip to content

Commit

Permalink
drop generic from concrete EntityManagers
Browse files Browse the repository at this point in the history
in the main branch for the project we have linting working as
expceted & it catches the generic `Entity` on these concrete
implementations as an unused definition - which it is

to fix that linting error this change removes the generic
hint from the concrete EntityManager
  • Loading branch information
imnotjames committed Sep 15, 2020
1 parent 589c543 commit c88c863
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/entity-manager/LiteralEntityManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import {createLiteralRepository} from "../repository/LiteralRepository";
* Entity manager supposed to work with any entity, automatically find its repository and call its methods,
* whatever entity type are you passing.
*/
export function createLiteralEntityManager<Entity>({ connection, queryRunner }: {
export function createLiteralEntityManager({ connection, queryRunner }: {
connection: Connection,
queryRunner?: QueryRunner,
}): EntityManager {
Expand Down
2 changes: 1 addition & 1 deletion src/entity-manager/LiteralMongoEntityManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ import { createLiteralEntityManager } from "./LiteralEntityManager";
*
* This implementation is used for MongoDB driver which has some specifics in its EntityManager.
*/
export function createLiteralMongoEntityManager<Entity>({ connection }: {
export function createLiteralMongoEntityManager({ connection }: {
connection: Connection,
}): MongoEntityManager {

Expand Down
2 changes: 1 addition & 1 deletion src/entity-manager/LiteralSqljsEntityManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { SqljsEntityManager } from "./SqljsEntityManager";
* A special EntityManager that includes import/export and load/save function
* that are unique to Sql.js.
*/
export function createLiteralSqljsEntityManager<Entity>({ connection, queryRunner }: {
export function createLiteralSqljsEntityManager({ connection, queryRunner }: {
connection: Connection,
queryRunner?: QueryRunner,
}): SqljsEntityManager {
Expand Down

0 comments on commit c88c863

Please sign in to comment.