Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty d.ts files are causing consumer errors due to @internal classes not being emitted #11

Closed
zakhenry opened this issue Jun 22, 2016 · 4 comments

Comments

@zakhenry
Copy link

zakhenry commented Jun 22, 2016

See microsoft/TypeScript#6022 - this may have actually been fixed, but the npm package needs to be recompiled with a later version that includes that fix? I get the following errors (using `typescript@next)

Building ts for [server]
/Users/zak/ubiquits/ubiquits/node_modules/typeorm/query-builder/QueryBuilder.d.ts(1,23): error TS2306: File '/Users/zak/ubiquits/ubiquits/node_modules/typeorm/query-builder/alias/Alias.d.ts' is not a module.
/Users/zak/ubiquits/ubiquits/node_modules/typeorm/repository/Repository.d.ts(4,51): error TS2306: File '/Users/zak/ubiquits/ubiquits/node_modules/typeorm/query-builder/transformer/PlainObjectToNewEntityTransformer.d.ts' is not a module.
/Users/zak/ubiquits/ubiquits/node_modules/typeorm/repository/Repository.d.ts(5,56): error TS2306: File '/Users/zak/ubiquits/ubiquits/node_modules/typeorm/query-builder/transformer/PlainObjectToDatabaseEntityTransformer.d.ts' is not a module.
/Users/zak/ubiquits/ubiquits/node_modules/typeorm/repository/Repository.d.ts(6,47): error TS2306: File '/Users/zak/ubiquits/ubiquits/node_modules/typeorm/persistment/EntityPersistOperationsBuilder.d.ts' is not a module.
/Users/zak/ubiquits/ubiquits/node_modules/typeorm/repository/Repository.d.ts(7,42): error TS2306: File '/Users/zak/ubiquits/ubiquits/node_modules/typeorm/persistment/PersistOperationExecutor.d.ts' is not a module.
[17:55:21] TypeScript: 5 semantic errors

On inspection, those d.ts files reporting errors are empty, and the source files have only classes with @internal jsdoc.

@pleerock
Copy link
Member

yeap Im aware of these errors. will fix them today

@zakhenry
Copy link
Author

Cool, if it helps any, RxJS implemented a workaround to suppress the error. Though I'm unsure if it is still actually an error with latest TS

@pleerock
Copy link
Member

fixed in 0.0.2-alpha.43 f5999cd..9ba0eb9

@zakhenry
Copy link
Author

👍 confirmed working now

pleerock pushed a commit that referenced this issue Sep 11, 2017
Kononnable added a commit that referenced this issue Oct 10, 2019
Adding some postgres specific types to the postgres driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants