Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite support for orUpdate #4096

Closed
emibloque opened this issue May 7, 2019 · 0 comments
Closed

SQLite support for orUpdate #4096

emibloque opened this issue May 7, 2019 · 0 comments

Comments

@emibloque
Copy link
Contributor

Issue type:

[ ] question
[ ] bug report
[x] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[ ] postgres
[ ] cockroachdb
[x] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

In this PR #3056, support for ON CONFLICT was added for MySQL and Postgres when using orUpdate, and in this PR #3190 support for Postgres onConflict was added for SQLite as they have the same syntax.

We want to have support of orUpdate override for SQLite, in order to have compatibility when using MySQL in production and SQLite in tests.

I'm going to create a PR for this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant